Skip to content

Conversation

@DrFaust92
Copy link
Contributor

No description provided.

@DrFaust92 DrFaust92 requested review from a team and imrannayer as code owners February 27, 2025 02:48
@gemini-code-assist
Copy link

Important

The terms of service for this installation has not been accepted. Please ask the Organization owners to visit the Gemini Code Assist Admin Console to sign it.

@DrFaust92 DrFaust92 changed the title Add lables to google_compute_ha_vpn_gateway feat: Add lables to google_compute_ha_vpn_gateway Feb 27, 2025
@imrannayer
Copy link
Collaborator

@DrFaust92 thx for the PR. Can you plz change min provider version to 6.21 in versions.tf as this feature was part of 6.21? This will be a breaking change with next version 5.0. Can you also add a document with details in docs folder

@imrannayer imrannayer changed the title feat: Add lables to google_compute_ha_vpn_gateway feat(TPG>= 6.21)!: Add lables to google_compute_ha_vpn_gateway Feb 27, 2025
@imrannayer imrannayer self-assigned this Feb 27, 2025
@DrFaust92
Copy link
Contributor Author

@DrFaust92 thx for the PR. Can you plz change min provider version to 6.21 in versions.tf as this feature was part of 6.21? This will be a breaking change with next version 5.0. Can you also add a document with details in docs folder

Thanks, Done, lmk if this is enough.

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit f9d73d9 into terraform-google-modules:main Feb 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants